Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #40

Merged
merged 1 commit into from
May 25, 2020
Merged

Fix warnings #40

merged 1 commit into from
May 25, 2020

Conversation

amoodie
Copy link
Member

@amoodie amoodie commented May 25, 2020

So I actually checked on #24, and there are only two print warnings in the bmi codes. I just changed them in place to use actual warnings, without changing anything else.

Moving forward, we just want to enforce using warnings rather than just printing info.

Closes #24

@amoodie
Copy link
Member Author

amoodie commented May 25, 2020

I clearly screwed something up with my branching, because the first two commits are supposed to be part of #37. Merge #37 first, then this PR. Should fix history when doing that.

@amoodie amoodie requested a review from elbeejay May 25, 2020 18:44
Copy link
Member

@elbeejay elbeejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings all work as you'd expect. Can be merged after the pre-requisite PRs have been handled.

@amoodie
Copy link
Member Author

amoodie commented May 25, 2020

thank @elbeejay I fixed the commit history, git rebase to the rescue! so I'm going to merge.

@amoodie amoodie merged commit 28ddc60 into DeltaRCM:develop May 25, 2020
amoodie added a commit to amoodie/pyDeltaRCM that referenced this pull request Feb 25, 2021
@amoodie amoodie deleted the fix_warnings branch February 25, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change print() warnings to actual warnings()
2 participants