Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

30 refactor code #33

Merged
merged 27 commits into from
May 29, 2024
Merged

30 refactor code #33

merged 27 commits into from
May 29, 2024

Conversation

veenstrajelmer
Copy link
Collaborator

No description provided.

@veenstrajelmer
moved data retrieval to functions
4ce51ae
@veenstrajelmer
moved plot timeseries to function
3a37436
@veenstrajelmer
moved plot timeseries to function
a03e0ff
@veenstrajelmer
minor
b984ab6
@veenstrajelmer
moved statistics to dedicated function
63d2ccd
@veenstrajelmer
minor fixes
d4f2546
@veenstrajelmer
prevent duplication of filenames and split up statistics in extremes …
e9ffa30 
…and ts
@veenstrajelmer
further simplified user script for retrieval
6b21885
@veenstrajelmer
cleaned monthly/yearly mean code for plot_measurements function
f8c8324
@veenstrajelmer
simplified yearly means
d8a1a6c
@veenstrajelmer
prevent exposure of private functions
629dde3
@veenstrajelmer
included conversion to dataframe and timezone correction in read_meas…
4f605f0 
…urements
@veenstrajelmer
also in plot_measurements
a028b88
@veenstrajelmer
moved statistics from dataset to dataframe
a13edda
@veenstrajelmer
moved statistics from dataset to dataframe
5bd438e
@veenstrajelmer
updated comments
e1dfaf8
@veenstrajelmer
updated comments
b319ae4
@veenstrajelmer
updated comments
d378002
@veenstrajelmer
also use read_measurements in kwk_process.py
c7cb2c3
@veenstrajelmer
move tidalindicators to separate script
0b4a642
@veenstrajelmer
exposed functions and fixed KWK_process.py so it runs again
2ae9b96
@veenstrajelmer
cleanup comments
7cdee07
@veenstrajelmer
fixed timezone diff in havengetallen
f1ce424
@veenstrajelmer
moved nap correction to read_measurements
c7bd056
@veenstrajelmer
moved nap correction to read_measurements
262816b
@veenstrajelmer
check amount of locations in function instead of duplicated code
1090308
@veenstrajelmer
moved function order
d155b99
@veenstrajelmer veenstrajelmer linked an issue May 29, 2024 that may be closed by this pull request
refactor code #30
Closed
14 tasks
@veenstrajelmer veenstrajelmer merged commit 07ea7b7 into main May 29, 2024
@veenstrajelmer veenstrajelmer deleted the 30-refactor-code branch May 29, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor code
1 participant
@veenstrajelmer