Feature/dei 85/parser formula rule #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IoannaMi
reviewed
May 3, 2023
| description, | ||
| ) | ||
|
|
||
| def _validate_formula(self, formula: str): |
There was a problem hiding this comment.
Should we do it similar as the other cases where if we received something that is not float or int we show to the message also the type that we received? perhaps also in the combine results rule we could do the same. What do you think?
| from decoimpact.data.entities.formula_rule_data import FormulaRuleData | ||
|
|
||
|
|
||
| def test_combine_results_rule_data_creation_logic(): |
There was a problem hiding this comment.
Should be: test_formula_rule_data_creation_logic
| exception_raised = exc_info.value | ||
|
|
||
| # Assert | ||
| expected_message = f"""Formula must be a string, \ |
There was a problem hiding this comment.
Similar questiona as previous comment related to the type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.