Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write documentation for MDU keywords #288

Closed
priscavdsluis opened this issue Jul 19, 2022 · 0 comments · Fixed by #382
Closed

Write documentation for MDU keywords #288

priscavdsluis opened this issue Jul 19, 2022 · 0 comments · Fixed by #382
Labels
type: enhancement Improvements to existing functionality
Milestone
0.3.1

Comments

@priscavdsluis
Copy link
Contributor

We would like to provide comments for all the keywords in the MDU file.
You can find the comments in the D-Flow FM manual (https://content.oss.deltares.nl/delft3d/manuals/D-Flow_FM_User_Manual.pdf, subsection A.1)

The comments should be written to file when saving the FMModel
@priscavdsluis priscavdsluis added the type: enhancement Improvements to existing functionality label Jul 19, 2022
@priscavdsluis priscavdsluis added this to the Release 0.4 milestone Jul 19, 2022
@priscavdsluis priscavdsluis mentioned this issue Jul 19, 2022
Merged
priscavdsluis added a commit that referenced this issue Oct 14, 2022
@priscavdsluis
#288: Add comments for General section MDU
f0c3b4f
priscavdsluis added a commit that referenced this issue Oct 14, 2022
@priscavdsluis
#288: Add comments for Numerics section MDU
f675f1b
priscavdsluis added a commit that referenced this issue Oct 14, 2022
@priscavdsluis
#288: Add comments for VolumeTables section MDU
13bf342
priscavdsluis added a commit that referenced this issue Oct 14, 2022
@priscavdsluis
#288: Add comments for VolumeTables section MDU
0f71dce
priscavdsluis added a commit that referenced this issue Oct 17, 2022
@priscavdsluis
#288: Add comments for Physics section MDU
3479d14
priscavdsluis added a commit that referenced this issue Oct 17, 2022
@priscavdsluis
#288: Add (empty) comments for Sediment section MDU
e7a5f5c
priscavdsluis added a commit that referenced this issue Oct 17, 2022
@priscavdsluis
#288: Add comments for Wind section MDU
864d3d1
priscavdsluis added a commit that referenced this issue Oct 17, 2022
@priscavdsluis
#288: Add comments for Waves section MDU
1303da8
priscavdsluis added a commit that referenced this issue Oct 17, 2022
@priscavdsluis
#288: Add comments for Time section MDU
59f8d56
priscavdsluis added a commit that referenced this issue Oct 17, 2022
@priscavdsluis
#288: Add comments for Restart section MDU
1b77027
priscavdsluis added a commit that referenced this issue Oct 17, 2022
@priscavdsluis
#288: Add comments for External Forcing section MDU
b9564b5
priscavdsluis added a commit that referenced this issue Oct 17, 2022
@priscavdsluis
#288: Add comments for Hydrology section MDU
ee6cfad
priscavdsluis added a commit that referenced this issue Oct 17, 2022
@priscavdsluis
#288: Add comments for Trachytopes section MDU
39f77a8
priscavdsluis added a commit that referenced this issue Oct 17, 2022
@priscavdsluis
#288: Add comments for Output section MDU
46d94a0
priscavdsluis added a commit that referenced this issue Oct 24, 2022
@priscavdsluis
#288: Add comments for Geometry section MDU
f0c0481
priscavdsluis added a commit that referenced this issue Oct 24, 2022
@priscavdsluis
#288: Add comments for Calibration section MDU
9bdae3a
priscavdsluis added a commit that referenced this issue Oct 24, 2022
@priscavdsluis
#288: Add comments for Grw section MDU
6fa233b
priscavdsluis added a commit that referenced this issue Oct 24, 2022
@priscavdsluis
#288: Add comments for Processes section MDU
ffbd479
priscavdsluis added a commit that referenced this issue Oct 24, 2022
@priscavdsluis
#288: Add comments for Particles section MDU
864cb4f
priscavdsluis added a commit that referenced this issue Oct 24, 2022
@priscavdsluis
#288: Add comments for Veg section MDU
f2f1835
priscavdsluis added a commit that referenced this issue Oct 24, 2022
@priscavdsluis
#288: Remove TODO
5db0589
@priscavdsluis priscavdsluis linked a pull request Oct 24, 2022 that will close this issue
288: Add documentation for MDU keywords #382
Merged
arthurvd pushed a commit that referenced this issue Oct 25, 2022
@priscavdsluis
docs: Add documentation for MDU keywords
b100338 
Refs: #288
@priscavdsluis priscavdsluis modified the milestones: Release 0.4, 0.3.1 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement Improvements to existing functionality
Projects
None yet
Milestone
0.3.1
Development

Successfully merging a pull request may close this issue.

288: Add documentation for MDU keywords Deltares/HYDROLIB-core
1 participant
@priscavdsluis