Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 'old' crs.pli files (observation cross sections) #364

Closed
veenstrajelmer opened this issue Oct 10, 2022 · 1 comment · Fixed by #464
Closed

Add support for 'old' crs.pli files (observation cross sections) #364

veenstrajelmer opened this issue Oct 10, 2022 · 1 comment · Fixed by #464
Assignees
@arthurvd @tim-vd-aardweg
Labels
type: feature Brand new functionality
Milestone
Release 0.5

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Oct 10, 2022 •
edited by arthurvd
Loading

Is your feature request related to a problem? Please describe.
Currently, crs (and obs) files are not supported by hydrolib. Upon reading them, the resulting dataset is empty. As a 2D modeller, I was not aware that this filetype is considered old, since it is being widely used in our models and therefore not possible to deprecate yet. Furthermore, I was not aware there existed a new alternative for it.

Describe the solution you'd like
Add support for _crs.pli files (_obs.xyn files is handled under separate issue #459).
@veenstrajelmer veenstrajelmer mentioned this issue Dec 14, 2022
Open
73 tasks
@arthurvd arthurvd added this to the Release 0.5 milestone Mar 7, 2023
@arthurvd arthurvd mentioned this issue Mar 10, 2023
Closed
@arthurvd arthurvd changed the title Add support for 'old' obs.xyn and crs.pli files (observationpoints and cross sections) Add support for 'old' crs.pli files (observation cross sections) Mar 10, 2023
@arthurvd arthurvd added the type: feature Brand new functionality label Mar 10, 2023
@arthurvd arthurvd self-assigned this Mar 10, 2023
@arthurvd arthurvd mentioned this issue Mar 13, 2023
Merged
@arthurvd arthurvd mentioned this issue Mar 13, 2023
Closed
@tim-vd-aardweg tim-vd-aardweg self-assigned this Mar 14, 2023
@veenstrajelmer
Copy link
Collaborator Author

Tested on branch 461_obscrs_in_FM

arthurvd added a commit that referenced this issue Mar 29, 2023
@arthurvd
feat: Support observation crosssection .pli via existing PolyFile cla…
fcea084 
…ss (#464)

Refs: #364.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurvd arthurvd

@tim-vd-aardweg tim-vd-aardweg

Labels
type: feature Brand new functionality
Projects
None yet
Milestone
Release 0.5
Development

Successfully merging a pull request may close this issue.

Add unit tests for obs crs.pli via existing PolyFile class Deltares/HYDROLIB-core
3 participants
@arthurvd @veenstrajelmer @tim-vd-aardweg