Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T3D header not correct #356

Merged
merged 48 commits into from
Oct 14, 2022
Merged

T3D header not correct #356

Show file tree
Hide file tree
Changes from 44 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
d47cf4e
Added ZSurf option for verticalPositionType.
tim-vd-aardweg Sep 29, 2022
1b48656
Added a child class that inherrits from QuantityUnitPair that also ha…
tim-vd-aardweg Sep 29, 2022
7282233
Fixed the aliases to adhere to the 2D3D manual.
tim-vd-aardweg Sep 29, 2022
0e70a0a
Reverted Time Interpolation back to the original timeInterpolation. U…
tim-vd-aardweg Sep 29, 2022
1a1163e
Added support for the timeInterpolation keyword when creating a T3D f…
tim-vd-aardweg Sep 29, 2022
096b2b8
Removed the QuantityUnitPositionPair class again, in favour of a bett…
tim-vd-aardweg Sep 30, 2022
4164906
Fixed failing tests as a result of making the QuantityUnitPair a Base…
tim-vd-aardweg Oct 3, 2022
105c9e8
Added new test for the QuantityUnitPair.
tim-vd-aardweg Oct 3, 2022
1c05236
Added documentation to the VerticalInterpolation enum.
tim-vd-aardweg Oct 3, 2022
15499a9
Added documentation to the TimeInterpolation enum.
tim-vd-aardweg Oct 3, 2022
91ddeef
Added documentation to the QuantityUnitPair class.
tim-vd-aardweg Oct 3, 2022
ea938a7
Updated documentation of ForcingBase to the new documentation style.
tim-vd-aardweg Oct 3, 2022
5d691e0
Added documenation to the T3D class.
tim-vd-aardweg Oct 3, 2022
c37deeb
Added validation: Ensure the first QuantityUnitPair is for `time`.
tim-vd-aardweg Oct 3, 2022
7d7a6cb
Intermediate commit of the new validation.
tim-vd-aardweg Oct 3, 2022
b417154
Intermediate commit of the new validation.
tim-vd-aardweg Oct 3, 2022
c50c71f
Fixed an error in the validator and fixed formatting.
tim-vd-aardweg Oct 3, 2022
735a3c8
Fixed some testcases and added a couple of testcases.
tim-vd-aardweg Oct 3, 2022
1a10026
Added additional testcases
tim-vd-aardweg Oct 4, 2022
bbde372
Added additional testcases
tim-vd-aardweg Oct 4, 2022
8d4d6f3
Added additional test cases.
tim-vd-aardweg Oct 4, 2022
fdebf78
Updated reference data for T3D
tim-vd-aardweg Oct 4, 2022
3a44fe3
Updated the remaining documentation for this file.
tim-vd-aardweg Oct 4, 2022
82b386a
autoformat: isort & black
tim-vd-aardweg Oct 4, 2022
3e24262
Fixed a bug with the `number_of_verticalpositions`. Implemented revie…
tim-vd-aardweg Oct 6, 2022
2cb275a
Use `Vertical Position` instead of `verticalpositionindex`
tim-vd-aardweg Oct 7, 2022
83c11f0
Updated keywords for the T3D header and added a test to ensure loadin…
tim-vd-aardweg Oct 7, 2022
87e78bd
Fixed code smells.
tim-vd-aardweg Oct 10, 2022
0694680
Fixed code smells.
tim-vd-aardweg Oct 10, 2022
f140d80
Add failing testcase that should pass
tim-vd-aardweg Oct 11, 2022
93e4f4b
Added a way to support the 'Vertical Position Specification' keyword …
tim-vd-aardweg Oct 11, 2022
aee2917
autoformat: isort & black
tim-vd-aardweg Oct 11, 2022
72c8d49
Merge branch 'main' into fix/317_t3d_header_not_correct
priscavdsluis Oct 12, 2022
0e1048a
Updated the keywords to the new keywords.
tim-vd-aardweg Oct 13, 2022
864ce5b
Merge branch 'fix/317_t3d_header_not_correct' of https://github.com/D…
tim-vd-aardweg Oct 13, 2022
5489c15
Updated error message to be more clear
tim-vd-aardweg Oct 13, 2022
88fb9fc
Added backwards compatibility for the keywords in the .bc file that u…
tim-vd-aardweg Oct 13, 2022
64b972c
autoformat: isort & black
tim-vd-aardweg Oct 13, 2022
f64a069
Added backwards compatibility for the `Time Interpolation` keyword in…
tim-vd-aardweg Oct 13, 2022
ae1d1a4
Added error when the user forgot to specify the vertpositions field t…
tim-vd-aardweg Oct 13, 2022
2e6bc19
Fixed the default enum values for timeinterpolation and verticalinter…
tim-vd-aardweg Oct 13, 2022
68a6cc5
Removed the check for this unit as it causes problems on the build se…
tim-vd-aardweg Oct 13, 2022
49c1575
Removed the ForcingBackwardsCompatibilityHelper and instead added a g…
tim-vd-aardweg Oct 13, 2022
dd24bf0
autoformat: isort & black
tim-vd-aardweg Oct 13, 2022
9f55295
Update hydrolib/core/io/bc/models.py
arthurvd Oct 13, 2022
5a9339a
Implemented review comments.
tim-vd-aardweg Oct 14, 2022
6c436bd
Merge branch 'main' into fix/317_t3d_header_not_correct
priscavdsluis Oct 14, 2022
0061257
autoformat: isort & black
priscavdsluis Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading