irregular to regular #322
Merged
irregular to regular #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillSenior
reviewed
Apr 24, 2024
BillSenior
reviewed
Apr 24, 2024
BillSenior
reviewed
Apr 24, 2024
Comment on lines
+155
to
+161
| Eigen::Matrix<UInt, 2, 2> matrix; | ||
| for (UInt i = 0; i < localI.size(); ++i) | ||
| { | ||
| if (localI[i] == minI && localJ[i] == minJ) | ||
| { | ||
| matrix(0, 0) = localNodes[i]; | ||
| } |
There was a problem hiding this comment.
In the loop below is every element of the matrix assigned a value? If not then should it be initialised with some default set of values
BillSenior
reviewed
Apr 24, 2024
Comment on lines
+2
to
+4
| // | ||
| // Copyright (C) Stichting Deltares, 2011-2023. | ||
| // |
There was a problem hiding this comment.
Might be a year out of date
BillSenior
reviewed
Apr 24, 2024
BillSenior
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.