Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of missing data in tables #389

Closed
SouthEndMusic opened this issue Jul 5, 2023 · 4 comments
Closed

Handling of missing data in tables #389

SouthEndMusic opened this issue Jul 5, 2023 · 4 comments
Labels
improvement Improvements of the usability of existing functionality needs-refinement Issues that are too large and need refinement

Comments

@SouthEndMusic
Copy link
Collaborator

As mentioned here.

@SouthEndMusic SouthEndMusic added the improvement Improvements of the usability of existing functionality label Jul 5, 2023
@visr
Copy link
Member

visr commented Jul 5, 2023

Thanks for creating this issue. This is partially supported right now, e.g. see

if !isnan(val)
, where we ignore NaN values when updating the forcing.

Both GeoPackage and Arrow have a general concept of missing data, separate from NaN which only exists for floats, and therefore is not an option for optional string fields like control_state. In julia NULL is normally encoded as missing, so a float that can be missing is Union{Float64, Missing}. So probably we should use that for everything that is allowed to be missing, unless there are other downsides compared to using NaN.

@SouthEndMusic
Copy link
Collaborator Author

@visr I guess this issue is solved now?

@visr
Copy link
Member

visr commented Jul 14, 2023

I don't think so. It's gotten better with your implementation of defaults in the julia core, but we still need testing and a clear story on how we handle optional data across ribasim-python and the core.

@SnippenE SnippenE added the needs-refinement Issues that are too large and need refinement label Aug 16, 2023
@visr
Copy link
Member

visr commented May 27, 2024

I think this can be closed now. Occasionally we adjust this a bit like in #1493. One thing worth adding is that we should always use NULL / missing rather that NaN in out input data.

@visr visr closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements of the usability of existing functionality needs-refinement Issues that are too large and need refinement
Projects
Archived in project
Development

No branches or pull requests

3 participants