Bedconc, SSconc and Sedconc are in g/m3 and not kg/m3

[aweerts]

Wflow version checks

• I have checked that the issue still exists on the latest versions of the docs on master here

Kind of issue

Docs are wrong

Location of the documentation

Sediment.jl line 761-763

Documentation problem

From: Hélène Boisgontier Helene.Boisgontier@deltares.nl
Sent: Wednesday, January 31, 2024 01:30
To: Albrecht Weerts Albrecht.Weerts@deltares.nl
Cc: Bart Moekestorm Bart.Moekestorm@deltares.nl; Athanasios Tsiokanos Athanasios.Tsiokanos@deltares.nl
Subject: RE: Ssconc unit

Hi Albrecht,

No you are right, the unit is mg/L or actually g/m3 rather than kg/m3.
The docs in wflow Julia is wrong then.

Can Bart open an issue in Wflow.jl so that this gets corrected at some point?

Cheers,
Hélène

From: Albrecht Weerts <Albrecht.Weerts@deltares.nl>
Sent: dinsdag 30 januari 2024 21:20
To: Hélène Boisgontier <Helene.Boisgontier@deltares.nl>
Cc: Bart Moekestorm <Bart.Moekestorm@deltares.nl>; Athanasios Tsiokanos <Athanasios.Tsiokanos@deltares.nl>
Subject: Ssconc unit

Hi Helene,

From Bart (MSc student) I get information that the wflow_sediment results only make sense if he assumes the SSconc output is in mg/l.
Otherwise, resulting cbagnold are extremely small and not in range of literature values
He multiplies the wflow_sediment output (SSconc) with discharge (m3/s) to get kg/s to be able to compare against the available measurements.
However, according to the documentation SSconc is in kg/m3.

However, when looking in the code I see also

Conversion from load [ton] to concentration for rivers [mg/L] (line 1550) Wflow.jl/src/sediment.jl at master · Deltares/Wflow.jl · GitHub

toconc = ifelse(rs.q_riv[v] > 0.0, 1e6 / (rs.q_riv[v] * rs.Δt), 0.0)

rs.SSconc[v] = SS * toconc (line 1594)
which suggests that SSconc is in mg/l?

In the old python code the equations look the same as above and are also in mg/l (wflow/wflow/wflow_sediment.py at master · openstreams/wflow · GitHub, line 2240/2251)

It would be good if we can get this cleared up.

Thanks!

With kind regards,

Albrecht Weerts

Suggested fix for documentation

replace "kg m-3" with "g m-3" equal to "mg/l"