Updated documentation #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
reviewed
Dec 23, 2021
Major changes are in structure and user guide
JoostBuitink
force-pushed
the
new_docs
branch
from
7313e88
to
2c35e46
Compare
- in Publications section include section about Citing wflow, leave out the draft paper on wflow_sbm - wrap lines and some small changes
- describe these concepts more apart, also for the user guide (e.g. model configurations) - some more line wrapping
verseve
requested changes
Feb 14, 2022
There was a problem hiding this comment.
Looks good @JoostBuitink ! See my review comments and some additional commits.
verseve
requested changes
Feb 15, 2022
hboisgon
reviewed
Feb 15, 2022
There was a problem hiding this comment.
Super nice new organisation of the docs @JoostBuitink ! And very nice new pictures for the SBM concepts :)
Here just a few comments mainly on install and usage.
use NCDatasets instead of ncinfo for example NetCDF output of forcing.
verseve
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the structure, and added a more detailed user guide
Edit: preview docs: https://deltares.github.io/Wflow.jl/previews/PR184/