Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename h_bankfull to bankfull_depth #198

Merged
merged 3 commits into from
Jan 28, 2022
Merged

rename h_bankfull to bankfull_depth #198

merged 3 commits into from
Jan 28, 2022

Conversation

DirkEilander
Copy link
Contributor

fixes #197

@DirkEilander
Copy link
Contributor Author

DirkEilander commented Jan 26, 2022 •
edited
Loading

I did not get the tests to run on my machine..

Could the failing tests have to do with a wflow config toml file that need to be updated somewhere? @verseve

@verseve
Copy link
Member

verseve commented Jan 26, 2022 •
edited
Loading

It now uses the actual riverdepth map for the kinematic wave, before this change the default value was used. This is causing some small differences. I think this is fine, we just need to change the test values.

@verseve
Copy link
Member

verseve commented Jan 28, 2022

Could you also please update the changelog (this is breaking)? And request a review?

@verseve verseve self-requested a review January 28, 2022 08:59
verseve
verseve approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@verseve verseve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this issue!

@verseve verseve merged commit d3d52fd into Deltares:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verseve verseve verseve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consistent naming of "bankfull_depth" parameter
2 participants
@DirkEilander @verseve