-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct flowelem_zcc bottom z-layer for z-sigma coordinates from reconstruction #417
Closed
4 of 5 tasks
Comments
This was referenced Jul 11, 2023
Closed
Closed
mgeraeds
added a commit
to mgeraeds/dfm_tools
that referenced
this issue
Jul 13, 2023
mgeraeds
added a commit
to mgeraeds/dfm_tools
that referenced
this issue
Jul 14, 2023
Most of the sub-issues were taken care of. The layer reconstruction now correctly derives z-values for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the reconstruction of mesh2d_flowelem_zcc, the layers are clipped to the bed level. Thus, the bottom z-layer of the mesh2d_flowelem_zcc coordinate is set equal to the bed level. This not correct, because the location of the mesh2d_flowelem_zcc should be halfway the bottom vertical grid cell. Also, with FullGridOutput on, the rest of the values below the clipped bed level are normally set to NaN, and that is not the case when reconstructing the mesh2d_flowelem_zcc and mesh2d_flowelem_zw quantities with the reconstruct_zw_zcc_fromzsigma function.
Requirements:
mesh2d_
inreconstruct_zw_zcc_fromzsigma()
#746zw is layer interfaces
zcc is layer centers
The text was updated successfully, but these errors were encountered: