Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare release v0.5.0 #170

Merged
merged 5 commits into from
Aug 4, 2022
Merged

prepare release v0.5.0 #170

merged 5 commits into from
Aug 4, 2022

Conversation

DirkEilander
Copy link
Contributor

@DirkEilander DirkEilander commented Aug 3, 2022 •
edited
Loading

  • bumped version to v0.5.0
  • matched dependencies in pyproj.toml with all environment yml files

@DirkEilander DirkEilander marked this pull request as ready for review August 3, 2022 14:06
hboisgon
hboisgon approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@hboisgon hboisgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two small comments for flit minimum version and hydroengine dependency.

binder/environment.yml Outdated
- zarr
- pip:
- hydroengine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you added hydroengine, do we need it in hydromt core? I thought just hydromt_wflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed hydroengine here and marked it optional in hydromt-dev.

binder/environment.yml Outdated
- black
- bottleneck
- cartopy # to run examples
- click
- dask
- descartes # to run examples
- entrypoints
- flit>=3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we do flit 3.4 to be sure pip install works ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. I've changed this in all environment files and the pyproj.toml

@DirkEilander DirkEilander merged commit e30a4f6 into main Aug 4, 2022
@DirkEilander DirkEilander deleted the v0.5 branch August 4, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboisgon hboisgon hboisgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DirkEilander @hboisgon