Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message for 0D geometry variable in GeoDataset #885

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Conversation

DirkEilander
Copy link
Contributor

@DirkEilander DirkEilander commented Apr 12, 2024

Issue addressed

Fixes #830

Explanation

Singe geometry geodatasets with zero dimensions are not discovered. While we can fix this it provides many other issues downstream as we also need a index dimension name which does not exist in this case. Hence I went with improving the GeoDataset typing and error messages.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed
  • For predefined catalogs: update the catalog version in the file itself, the references in data/predefined_catalogs.yml, and the changelog in data/changelog.rst

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@DirkEilander DirkEilander changed the title fix single geometry geodataset fix error message for 0D geometry variable in GeoDataset Apr 12, 2024
Copy link
Contributor

@hboisgon hboisgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And as mentioned in the issue happy with sel using a list as a workaround and only improving the error message here.

@savente93 savente93 merged commit 5dabbc3 into main Apr 17, 2024
9 of 10 checks passed
@savente93 savente93 deleted the fix/830 branch April 17, 2024 08:27
@savente93 savente93 mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handling of single-point geometries by update_geometry() in vector.py
3 participants