Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated .gitattributes for working with yaml files on Windows #930

Merged
merged 1 commit into from
May 21, 2024

Conversation

Tjalling-dejong
Copy link
Contributor

@Tjalling-dejong Tjalling-dejong commented May 21, 2024

Issue addressed

Fixes #

Explanation

Explain how you addressed the bug/feature request, what choices you made and why.

General Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation
  • Updated changelog.rst

Data/Catalog checklist

  • data/catalogs/predefined_catalogs.yml has not been modified.
  • None of the old data_catalog.yml files have been chagned
  • data/chagnelog.rst has been updated
  • new file uses LF line endings (done automatically if you used update_versions.py)
  • New file has been tested locally
  • Tests have been added using the new file in the test suite

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@Tjalling-dejong Tjalling-dejong marked this pull request as ready for review May 21, 2024 09:57
@savente93
Copy link
Contributor

We could be strikter on which files we do this for, but for now this is okay. This is to make sure line endings in binary files such as PNG aren't updated and give weird changes in new PRs.

@savente93 savente93 merged commit 7cfa04a into main May 21, 2024
2 checks passed
@savente93 savente93 deleted the yaml_line_endings branch May 21, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants