Feat/489 refactor resilience curve and adjusting the calculation #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…loss_per_capita-of-the-losses-module
ArdtK
changed the title
…ta-of-the-losses-module' into feat/489-adjusting-the-calculation
…ta-of-the-losses-module' into feat/489-create-dataclasses-with-readers-for-losses-csvs
…_period to ana config
Co-authored-by: Sahand Asgarpour <133748876+sahand-asgarpour@users.noreply.github.com>
…ps://github.com/Deltares/ra2ce into feat/489-traffic-intensities-per-traffic-period
ArdtK
changed the title
…loss_per_capita-of-the-losses-module
Carsopre
requested changes
Jul 2, 2024
tests/analysis/losses/resilience_curves/test_resilience_curves.py
Outdated
Show resolved
Hide resolved
ra2ce/analysis/losses/resilience_curves/resilience_curves_reader.py
Outdated
Show resolved
Hide resolved
…ta-of-the-losses-module' into feat/489-create-dataclasses-with-readers-for-losses-csvs
7 tasks
Carsopre
approved these changes
Jul 5, 2024
Comment on lines
+28
to
+30
| resilience_curves: dict[ | ||
| tuple[RoadTypeEnum, tuple[float, float]], list[tuple[float, float]] | ||
| ] = field(default_factory=dict) |
There was a problem hiding this comment.
Although I like this approach slightly more I believe it could be simplified with just a specific class representing the tuple[RoadTypeEnum, tuple[float,float]
Carsopre
deleted the
feat/489-update-the-_calculate_production_loss_per_capita-of-the-losses-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Solves #489
Code of conduct
What has been done?
A subpackage with dataclass and related reader is created for resilience_curve.
Losses_base is adjusted to using this new subpackage.
The new dataclass is used to extract the right data for the loss per capita calculation
Checklist
blackandisortdefinitions.master.Additional Notes (optional)
N.A.