Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CI testing for Python >= 3.8 or drop older Python versions? #129

Closed
mwtoews opened this issue Mar 5, 2024 · 1 comment · Fixed by #130
Closed

Restore CI testing for Python >= 3.8 or drop older Python versions? #129

mwtoews opened this issue Mar 5, 2024 · 1 comment · Fixed by #130

Comments

@mwtoews
Copy link
Contributor

mwtoews commented Mar 5, 2024

CI testing for Python 3.8 and 3.9 was removed via f879240 even though this project should support python>=3.8. This lets breaking changes like #128 slip in. (The issue is only related to Python 3.8, and is a typing discrepancy related to PathLike[Any] vs PathLike). Some choices are:

  1. Restore testing the minimum supported Python version in CI.yml, which will require fixing the typing issue. If fewer Python versions are desired, then test at least the oldest and newest supported versions, e.g. 3.8, 3.10, 3.12.
  2. Or drop Python 3.8 since it will be dropped in October 2024 (PEP 569). This option should probably keep Python 3.9, as this will be around until October 2024 ([PEP 596], but it would need to be added to CI.yml.

I don't have any strong preference, so I'll let @Hofer-Julian weigh in.

@Hofer-Julian
Copy link
Contributor

I don't have any strong preference, so I'll let @Hofer-Julian weigh in.

So far I always supported the last three Python versions.
But you are right, we then should also update the minimum required Python version in the pyproject.toml

Hofer-Julian added a commit that referenced this issue Mar 6, 2024
Hofer-Julian added a commit that referenced this issue Mar 6, 2024
Also add 3.9 back to CI
Fixes #129
Hofer-Julian added a commit that referenced this issue Mar 6, 2024
Also add 3.9 back to CI
Fixes #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants