Feature/division maps #1667
Merged
Feature/division maps #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoWill
force-pushed
the
feature/division-maps
branch
from
d1e32e9
to
7ae4cfc
Compare
symroe
force-pushed
the
feature/division-maps
branch
from
7ae4cfc
to
435118d
Compare
Only show it if there is a geography associated with an election object. This means that election groups with an associated object (eg local authorities /elections/local.aberdeen-city.2022-05-05/) will also show a map. To avoid cluttering the page, hide it in a details tag. Leaflet needs the div with the target id to be added to the dom before it's initialised. This is the reason for the eventListener on the detail. Includes a not very informative popup that can be improved upon.
symroe
force-pushed
the
feature/division-maps
branch
from
435118d
to
8e2dce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge before #1637 - I based this PR off of that branch as I couldn't get master working locally.Why
Becasue maps. More seriously the specific itch is wanting to know that the data councils have sent for WDIV covers the election area. This provides a nice way of quickly seeing the area covered by an election, and downloading the geojson to drag and drop into QGIS is a couple of clicks away.
Screenshots
Initial view with the detail collapsed
Expanded with the map open
Clicking the link on the popup downloads the geojson
