Wi p pollingstations refactor #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoWill
force-pushed
the
WiP-pollingstations-refactor
branch
2 times, most recently
from
693ffb8
to
d6a29c3
Compare
Our current scraping model deals with all the stations and all the districts, so for now I'm just going to reimplement that here. If there's some advantage to scraping individual stations/districts that can be handled down the line.
GeoWill
force-pushed
the
WiP-pollingstations-refactor
branch
from
d6a29c3
to
e8d89c0
Compare
symroe
reviewed
Jun 14, 2021
| from lgsf.path_utils import load_scraper, load_council_info | ||
|
|
||
|
|
||
| class Command(PerCouncilCommandBase): |
There was a problem hiding this comment.
Feels like a large chunk of this file could be refactored in to a common file - it's largely the same as the councillors one, and it would be good to keep the outputs and interfaces as similar as we can I think.
This can be an issue of course, not needed for this PR
| from lgsf.polling_stations.scrapers.xml_scrapers import GmlScraper | ||
|
|
||
|
|
||
| class Scraper(GmlScraper): |
There was a problem hiding this comment.
FWIW, I think this is really nice and readable. Not convinced that having two classes (PollingScraper and DistrictsScraper) would be any easier for a developer to work on. There might be other reasons to have them of course.
GeoWill
force-pushed
the
WiP-pollingstations-refactor
branch
from
52f858f
to
60c43df
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of https://github.com/wdiv-scrapers/dc-base-scrapers
Rational is to only have maintain one set of tooling/checks/deployment stuff around scraping 'types of thing' from multiple councils.
We will have to do this quite well for the reps work, so we might as well reap the benefits for polling stations - which neede some love anyway.