Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what I found:
With that in mind, this PR does a very basic handling of bad URLs: it renders a
notFound
template but still gives a 200 HTTP status. All URLs with the form oflocalhost:3000/somethingrandom
orlocalhost:3000/some/randomorunknonw/path
render thenotFound
template. Note that this takes care oflocalhost:3000/peer
(which was a TODO inroutes.js
).URLs with the form of
localhost:3000/vote/whatver
,localhost:3000/peer/whatever
, etcetera, currently just show an empty template (with no errors). I'm suggesting to leave it this way for now, because the current solution just feels too hacky. Longer term, it might be best to migrate to FlowRouter.Fixes #84