Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic handling for bad URLs #89

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Basic handling for bad URLs #89

merged 1 commit into from
Dec 16, 2016

Conversation

medied
Copy link
Member

@medied medied commented Dec 16, 2016

Here's what I found:

One other difference—and perhaps the elephant in the room—is that the Iron Router project has started to slow down a bit in terms of active development and response to issues. While there hasn't been any official statement around whether or not work on the project will continue, many have expressed concern about this. Flow Router, in contrast, is seeing a lot of active development

With that in mind, this PR does a very basic handling of bad URLs: it renders a notFound template but still gives a 200 HTTP status. All URLs with the form of localhost:3000/somethingrandom or localhost:3000/some/randomorunknonw/path render the notFound template. Note that this takes care of localhost:3000/peer (which was a TODO in routes.js).

URLs with the form of localhost:3000/vote/whatver, localhost:3000/peer/whatever, etcetera, currently just show an empty template (with no errors). I'm suggesting to leave it this way for now, because the current solution just feels too hacky. Longer term, it might be best to migrate to FlowRouter.

Fixes #84

@santisiri
Copy link
Member

It's in the Issues to do a migration to FlowRouter. It does seem to have become the standard for meteor since its faster and with more community support right now.

@santisiri santisiri merged commit a7b2f7a into staging Dec 16, 2016
@santisiri santisiri deleted the fix-84-bad-urls branch December 28, 2016 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants