Xuanying #957 disable carousel auto advance #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2023 17:24
SleeplessRegina
requested review from
PeterBreen and
marlonkeating
and removed request for
PeterBreen
PeterBreen
requested changes
Apr 12, 2023
| @@ -263,7 +263,7 @@ class CorporateHackathonController extends React.PureComponent<{||}, State> { | |||
| <div className="corporate-hackathon-carousel carousel-testimonial-root"> | |||
| <TestimonialCarousel | |||
| category="partner-highlights" | |||
| interval={600000} | |||
| interval={null} | |||
There was a problem hiding this comment.
Do we need to use interval={null} here, as well as in the TestimonialCarousel component itself? Carousel shouldn't be taking any props so I'm hoping it's safe to remove, but please test and let me know?
| @@ -409,7 +409,7 @@ class CorporateHackathonController extends React.PureComponent<{||}, State> { | |||
| <div className="corporate-hackathon-carousel carousel-testimonial-root"> | |||
| <TestimonialCarousel | |||
| category="hackathon-highlights" | |||
| interval={600000} | |||
| interval={null} | |||
There was a problem hiding this comment.
Same question as above
| @@ -363,7 +363,7 @@ class LandingController extends React.PureComponent<{||}, State> { | |||
| <h2 className="text-center LandingController-section-header"> | |||
| What people are saying about DemocracyLab | |||
| </h2> | |||
| <TestimonialCarousel interval={15000} /> | |||
| <TestimonialCarousel interval={null} /> | |||
There was a problem hiding this comment.
Same question as above
Yes, I removed the interval props of TestimonialCarousel then tested again and found it still looks good. Both the carousel won't automatically advance. |
PeterBreen
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable carousel auto advance, make the carousel only support manually advance both in TestimonialCarousel and BlogCarousel.
Set the custom intervals to null and remove interval from our type statement.