Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adaptor showing up under graphite - under local folder #66

Closed
mmccuiston opened this issue Oct 2, 2012 · 2 comments
Closed

adaptor showing up under graphite - under local folder #66

mmccuiston opened this issue Oct 2, 2012 · 2 comments
Assignees
@jimfcarroll
Labels
enhancement
Milestone
0.7.1

Comments

@mmccuiston
Copy link

When we view the graphite dashboard we find that the ProbeAdaptor shows up in a location marked "local" instead of a location using the client machines' IP address.

However being that the Probe Adaptor is not an MP - the code in

StatsCollectorFactoryCoda::buildPrefix

line 146: if (destination != null && destination instanceof TcpDestination)

Causes the prefix to default to "local" and the ProbeAdaptor stats wind up in the default "local" bucket which is confusing to the QA folks.
@jimfcarroll
Copy link
Collaborator

Thanks for digging into this and finding the exact location. It should be an easy fix.

@ghost ghost assigned jimfcarroll Oct 2, 2012
jimfcarroll pushed a commit to jimfcarroll/dempsy that referenced this issue Oct 6, 2012
[fix] Fixed the issue where Adaptor's don't show up in the monitoring…
4c83049 
… statistics in a consistent place with the other clusters in the application. This closes issue Dempsy#66.
@jimfcarroll jimfcarroll mentioned this issue Oct 6, 2012
Merged
@jimfcarroll
Copy link
Collaborator

Closed by PR64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimfcarroll jimfcarroll

Labels
enhancement
Projects
None yet
Milestone
0.7.1
Development

No branches or pull requests
2 participants
@jimfcarroll @mmccuiston