mapping change contributor for lambda params #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't require adding the LambdaClosure to the interface method
DenWav
force-pushed
the
feature/copy-lambda-params
branch
from
7996fc7
to
7a34d6e
Compare
I can't think of a scenario where it makes sense for these to merge or conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two approaches are implemented here, only 1 should be added.
One approach is to, first, in the LambdaCallHydrator, also add each call to the target interface method. Then in the mapping ChangeContributor, when you encounter a functional interface method, iterate over all the lambdas and update the mappings appropriately.
The alternative is to not make any changes to LambdaCallHydrator, and instead wait until you encounter a synthetic method with a matching LambdaClosure, then fetch the interface method's mappings and apply.