Update ChunkTag, AreaContainmentObject and ColorTag tag param usage.
#2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tal5
reviewed
Aug 28, 2022
| return null; | ||
| } | ||
| LocationTag loc = attribute.paramAsType(LocationTag.class); | ||
| processor.registerTag(ElementTag.class, LocationTag.class, "contains", (attribute, area, loc) -> { | ||
| if (loc == null) { |
There was a problem hiding this comment.
Can remove these null checks, as the new argument handling makes sure the param is present and valid
There was a problem hiding this comment.
Oh awesome! I'll push the changes right now :)
New tag processing makes sure the parameter is valid as pointed out by @tal5!
tal5
reviewed
Aug 28, 2022
| if (mixed_with != null) { | ||
| return new ColorTag(object.mixWith(mixed_with)); | ||
| tagProcessor.registerTag(ColorTag.class, ColorTag.class, "mix", (attribute, object, mixWith) -> { // Temporarily non-static because the input could be 'random' | ||
| if (mixWith != null) { |
There was a problem hiding this comment.
Can remove null check and the error here as well
There was a problem hiding this comment.
Got it! 🙌 Pushing the change now
BreadcrumbIsTaken
changed the title
ChunkTag and AreaContainmentObject tag param usage.ChunkTag, AreaContainmentObject and ColorTag tag param usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
ChunkTag,AreaContainmentObject, andColorTagtag param usage, as per request from issue #2355.Tags updated:
<AreaObject.contains[]><AreaObject.blocks_flagged[]><AreaObject.is_within[]><AreaObject.with_world[]><ChunkTag.add[]><ChunkTag.sub[]><ChunkTag.blocks_flagged[]><ColorTag.mix[]>Now they use the new ✨ fancy ✨ automated attribute processing.
I think I did this right. When I tested it it worked the same so :)
ive never used java before in my life 😳