Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get WEBHOOK_BODY from env #236

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Get WEBHOOK_BODY from env #236

merged 1 commit into from
Jan 8, 2023

Conversation

abgd1234
Copy link
Contributor

@abgd1234 abgd1234 commented Jan 8, 2023

There's a missing line of code to set webhook.body from the environment variables. At the moment, setting WEBHOOK_BODY does nothing, which is clearly a bug.

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Base: 41.73% // Head: 41.77% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (5d3ea3c) compared to base (f7a9518).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   41.73%   41.77%   +0.04%     
==========================================
  Files          20       20              
  Lines        1179     1180       +1     
==========================================
+ Hits          492      493       +1     
  Misses        687      687              
Impacted Files Coverage Δ
src/models/config.py 87.15% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Der-Henning
Copy link
Owner

Oh wow thank you. I should really write more tests ...

image

@Der-Henning Der-Henning merged commit aea1e67 into Der-Henning:main Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants