Ensure uri-compatible strings are used on windows #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the first two arguments to io.bit3.jsass.importer.Import. are going to be treated as URIs we need to ensure that the strings passed to the constructor are URI compatible (i.e. not contain backslashes or other illegal characters). This motivates both changes. Also we don't want windows users to have to import webjars using something like `@import "boostrap\\scss/bootstrap`. This is another reason for the change to webjars.clj.
|
Thanks. Have you tested this on Windows? Any other problems? |
|
This fixes the two problems I ran into on Windows. The |
|
Great! |
Deraen
added a commit
that referenced
this pull request
Jan 15, 2016
Ensure uri-compatible strings are used on windows
|
This has now been deployed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the first two arguments to io.bit3.jsass.importer.Import. are
going to be treated as URIs we need to ensure that the strings passed to
the constructor are URI compatible (i.e. not contain backslashes or
other illegal characters). This motivates both changes.
Also we don't want windows users to have to import webjars using
something like
@import "boostrap\\scss/bootstrap. This is anotherreason for the change to webjars.clj.