Add support for parenthesized expressions & EXISTS subquery #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I've enabled branch protection to require at least 1 approval & all the test suites passing before merging a PR |
matthias-Q
reviewed
Mar 23, 2023
ref: https://dev.mysql.com/doc/refman/8.0/en/exists-and-not-exists-subqueries.html ref: https://www.postgresql.org/docs/current/functions-subquery.html Skipped `NOT IN` b/c it's non-trivial, there are issues with precedence & conflicts.
DerekStride
force-pushed
the
ds/exists-with-parenthesis
branch
from
4d451ac
to
0b9c789
Compare
|
I've update the PR (& the PR description) to include the suggested changes. The one exception was |
|
LGTM |
matthias-Q
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There's three changes being made in this PR, each are contained to individual commits.
(&)to group them.EXISTSexpression.INNOT IN, there was conflicts with precedence that I want to sort out separately.ANY,SOME, &ALL