Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to build TeaStore as a monolithic (single container) application no longer available #216

Closed
ramironagles opened this issue Jun 2, 2022 · 9 comments
Assignees

Comments

@ramironagles
Copy link

There used to be an option to build TeaStore as a monolithic application (v 1.3.8) but it is not the case anymore.
If I load v 1.3.8 the links take me to the current version and there is a reference to the TeaStore wiki where the "Deploy the TeaStore in one or several Java Application Container(s)" is offered but the actual link (https://github.com/DescartesResearch/TeaStore/wiki/Getting-Started#deploy-the-pet-supply-store-in-java-application-containers) is broken and/or misleading (why is it talking about the 'pet-supply-store'?)

@SimonEismann
Copy link
Contributor

Hi ramironagles,

we recently discontinued the teastore-all image, since it became hard to maintain due to its outdated approach.

Do you need the newest TeaStore version? Otherwise, you could try the old teastore-all images:
https://hub.docker.com/r/descartesresearch/teastore-all

In the future, we were considering offering a new teastore-all image that uses docker-in-docker to run all services inside a single container as this solution would be much easier to maintain. This was not on the roadmap currently, since we were not aware of anybody using the teastore-all image.

PS: PetSupplyStore was the name we used internally before settling on TeaStore, so the link you found is pretty old :) Where exactly is that link? Then I'll fix that :)

@ramironagles
Copy link
Author

ramironagles commented Jun 6, 2022 via email

@ramironagles
Copy link
Author

I was wondering if there is any chance for us to clone/fork the source code repository used to build the monolithic teastore-all image (the link points to a docker image but not the source code repo).
We need to introduce some 'bugs' in the application to illustrate some performance-monitoring scenarios and that is why we need the source code so we can modify it and re-build it.

@SimonEismann
Copy link
Contributor

The workshop you are building sounds great, feel free to keep us posted on how it's coming along and if we can help with anything :)

I've been doing some digging, and this seems to be the last commit that contains the teastore-all image: https://github.com/DescartesResearch/TeaStore/tree/b37abaef0a9a4b4ecedc3430ec6ae9b5cc99d8f9

Based on the dockerfile, it seems that this version simply deploys all services on the same tomcat server. Would that already be sufficient for your workshop? Because in many regards this will still be a "distributed" application, where all distributed pieces are running on the same application server, but still communicate via REST calls.

In case you really need a monolithic version, this would require some reworking. Fortunately, at first glance, I think this should not be too much work. It would mostly mean merging the code bases and replacing the REST calls with direct calls to the respective functions. If this is something you would be interested in, we could schedule a call to go over how to approach this.

@ramironagles
Copy link
Author

Simon,
Thank you so much for looking into this!. I would be very interested in setting up a call to discuss what needs to be done to convert TeaStore in a 100% monolithic application.
Please let me know what dates and times work for you this week so we can schedule the call. I am located in the US CST time zone.
Thanks in advance.

@SimonEismann
Copy link
Contributor

Sorry for the late reply, things have been a bit busy. Could you reach out via email to schedule a meeting?

My contact information:
https://se.informatik.uni-wuerzburg.de/software-engineering-group/staff/simon-eismann/

@SimonEismann
Copy link
Contributor

Closing this since we resolved this offline :)

@ramironagles
Copy link
Author

ramironagles commented Jul 27, 2022 via email

@SimonEismann
Copy link
Contributor

Great to hear that everything worked out!

Please let me know if you want to be kept in the loop in regards to the ways we are using TeaStore in the future.

Of course, we are always excited to hear how people are using the TeaStore :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants