Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved version of script to autoformat the code #43

Closed
wants to merge 2 commits into from

Conversation

Informeli
Copy link

I don't know how to upload new code to an old pull request this is a followup from a statement of a maintainer.

@Arcnor Arcnor self-assigned this Apr 17, 2024
@Arcnor
Copy link
Collaborator

Arcnor commented Apr 17, 2024

Hi, thanks for the PR! However, this is making things worse :). This is basically trying to run the formatter half a dozen times, and it still uses the incorrect format (it should not use style, and it should do it in place instead).

I think for now we're going to ignore the formatter until everything is settled, then we can come back to this.

@Arcnor Arcnor closed this Apr 17, 2024
@Informeli
Copy link
Author

Hi, thanks for the PR! However, this is making things worse :). This is basically trying to run the formatter half a dozen times, and it still uses the incorrect format (it should not use style, and it should do it in place instead).

I think for now we're going to ignore the formatter until everything is settled, then we can come back to this.

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants