Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSplineSurface3D: point3d_to_2d #1241

Merged
merged 6 commits into from
Jan 12, 2024
Merged

BSplineSurface3D: point3d_to_2d #1241

merged 6 commits into from
Jan 12, 2024

Conversation

GabrielJMS
Copy link
Contributor

@GabrielJMS GabrielJMS commented Jan 11, 2024 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit messages follows our guidelines (explicit, in english)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix:
  • New features:
  • Documentation
  • Optimization
  • Other information:
    Enhancements for really challenging surfaces, like in the exemple bellow. A spiral that's also a periodical surface in u direction.
    image

image

@GabrielJMS GabrielJMS mentioned this pull request Jan 11, 2024
Closed
8 tasks
@WirajanDASILVA WirajanDASILVA merged commit 813f630 into dev Jan 12, 2024
2 checks passed
@WirajanDASILVA WirajanDASILVA deleted the bsplinesurface_point3d_to_2d branch January 12, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WirajanDASILVA WirajanDASILVA WirajanDASILVA approved these changes

Assignees
No one assigned
Labels
status: ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabrielJMS @WirajanDASILVA