Misc. enhancements to OpenXR and OpenVR API usage #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to documentation, this unblocks the compositor after presenting. It's optional but seems like a good practice, as WaitGetPoses won't get called until next Render call.
My understanding of the documentation is that the application version needs to be defined. The engine name is required to be a zero terminated string but I guess due to stack variable semantics it was already implicitly set correctly.
|
Thanks. Cherry-picked 2/3 of the commits. Reference space was created already so I left that one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some things I've noticed while reading through documentation. They don't noticeably change anything but seem like the right thing to do. Feel free to cherry-pick just what you're comfortable with.