-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Reorganize Sidebar #686
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ajwootto - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@ajwootto is this ready for a review? |
you can take a look and let me know what you think of how its organized but i realized it also breaks a bunch of links from our dashboard and various other places. I'm not sure if there's a good way to automatically continue redirecting from the old URLs when we do this kind of moving stuff around |
Looks like the are some merge conflicts now either way... For the redirect stuff, its just figuring out what they are and then updating this list: |
theres so many though :( |
@ajwootto this needs to have some of the merge errors resolved if we are going to move forward... |
Re-organize extras sidebar around "topics"