Remove unnecessary style mixins #6430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DokaRus
requested review from
BingoRUS,
churkin,
mrjohn0011 and
AntonSermyazhko
churkin
approved these changes
Dec 17, 2018
BingoRUS
reviewed
Dec 17, 2018
| -ms-backface-visibility: @prop; | ||
| backface-visibility: @prop; | ||
| } | ||
|
|
||
| .flip-horizontally() { |
There was a problem hiding this comment.
Why not to inline this mixin?
There was a problem hiding this comment.
The most part of our mixins just pass setup to standard and vendor-prefixed properties (doing autoprefixer's job).
This mixin is "syntax sugar" unlike the others, so we can сontinue to use it.
BingoRUS
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AntonSermyazhko added CSS autoprefixer in the #5148. So we can remove the most part of mixins.
This PR resolves #6403