Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS AutoPrefixer #5148

Merged
merged 2 commits into from
Aug 27, 2018
Merged

Add CSS AutoPrefixer #5148

merged 2 commits into from
Aug 27, 2018

Conversation

AntonSermyazhko
Copy link
Contributor

No description provided.

@AntonSermyazhko AntonSermyazhko self-assigned this Aug 22, 2018
@AntonSermyazhko AntonSermyazhko force-pushed the AutoPrefixer branch 2 times, most recently from 8125161 to 4e2df2b Compare August 22, 2018 12:12
lukyanovas
lukyanovas previously approved these changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@lukyanovas lukyanovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekseyMartynov
Copy link
Contributor

Now when we have autoprefixer, should we clean manually coded prefixes?

DevExtreme/styles/widgets/ui.less

Lines 58 to 61 in 2ba8f52

-webkit-transform: translate3d(100%, 0, 0);
-moz-transform: translate3d(100%, 0, 0);
-o-transform: translate3d(100%, 0, 0);
transform: translate3d(100%, 0, 0);

@AntonSermyazhko
Copy link
Contributor Author

Yes, we should. Adding prefixes is an autoprefixer job.

lukyanovas
lukyanovas previously approved these changes Aug 24, 2018
View reviewed changes
@AlekseyMartynov
Copy link
Contributor

@lukyanovas wait wait, it will get even better!

DokaRus
DokaRus reviewed Aug 24, 2018
View reviewed changes
package.json Outdated
@@ -104,5 +105,11 @@
"dev": "gulp dev",
"test-env": "node testing/launch"
},
"browserslist": [
"last 2 versions",
"ios > 7",
Copy link
Contributor

@DokaRus DokaRus Aug 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ios > 8? 8.x => ~0.45%
https://data.apteligent.com/ios/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen the separate file browserslist in some projects. Is it possible to extract such file here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for me, not a problem to increase the version of iOS to 9+.
Think that a separate file will be superfluous.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nightskylark
package.json is easier to read.
.browserslistrc has comments, etc, and it's not supported automatically by the plugin

@AntonSermyazhko AntonSermyazhko merged commit a9f0036 into DevExpress:18_2 Aug 27, 2018
@DokaRus DokaRus mentioned this pull request Dec 17, 2018
Merged
@lukyanovas lukyanovas mentioned this pull request Dec 17, 2018
Closed
@AntonSermyazhko AntonSermyazhko deleted the AutoPrefixer branch December 17, 2018 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DokaRus DokaRus DokaRus left review comments

@AlekseyMartynov AlekseyMartynov AlekseyMartynov approved these changes

@lukyanovas lukyanovas lukyanovas left review comments

@kvet kvet Awaiting requested review from kvet

@ovchinnikov ovchinnikov Awaiting requested review from ovchinnikov

@nightskylark nightskylark Awaiting requested review from nightskylark

@dxbykov dxbykov Awaiting requested review from dxbykov

Assignees

@AntonSermyazhko AntonSermyazhko

Labels
18_2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AntonSermyazhko @AlekseyMartynov @DokaRus @nightskylark @lukyanovas