Make it possible to configure SAUCE_API_HOST from environment #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just what I need 👍 |
fpoppinga
force-pushed
the
eu-datacenter
branch
from
9742aa8
to
e299f54
Compare
|
@AlexanderMoskovkin would you kindly review this PR? :) |
* bump version of sauce-connect-launcher * add environment variable which sets the SAUCE_API_HOST. This is required to use the new EU datacenter. * use this variable in all the places
fpoppinga
force-pushed
the
eu-datacenter
branch
from
e299f54
to
e624abe
Compare
|
Or maybe @AndreyBelym, do you have any input on this? |
|
I would really like this feature to be merged due to network latency problems with US SauceLabs. |
|
Very good, I would really like to see this PR merged as well. |
|
Thank you for your contribution, I'll publish it and update |
|
Great, I'll wait for the update of the browser provider! |
|
@douwekasemier thank you for your patience, I've published testcafe-browser-provider-saucelabs@1.7.0 that contains the updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required to use the new EU datacenter.
Cf. bermi/sauce-connect-launcher#140 for a similar change in sauce-connect-launcher.