Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing incorrect scroll to element obscured by sticky element #8047

Merged
merged 8 commits into from
Nov 10, 2023
Merged

fixing incorrect scroll to element obscured by sticky element #8047

merged 8 commits into from
Nov 10, 2023

Conversation

PavelMor25
Copy link
Collaborator

@PavelMor25 PavelMor25 commented Oct 19, 2023 •
edited
Loading

Purpose

Actions doesn't scroll correctly to element behind a sticky element

Approach

Added function which check element on property sticky.
Made refactor in scroll action

References

issue 7377

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Oct 19, 2023
@PavelMor25 PavelMor25 temporarily deployed to CI October 19, 2023 10:09 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Oct 19, 2023
@PavelMor25 PavelMor25 closed this Oct 19, 2023
@PavelMor25 PavelMor25 reopened this Oct 19, 2023
@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Oct 19, 2023
@PavelMor25 PavelMor25 temporarily deployed to CI October 19, 2023 10:59 — with GitHub Actions Inactive
@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Oct 19, 2023
AlexKamaev
AlexKamaev requested changes Oct 23, 2023
View reviewed changes
src/client/core/scroll/index.ts Outdated Show resolved Hide resolved
src/client/core/scroll/index.ts Outdated Show resolved Hide resolved
test/functional/fixtures/regression/gh-7377/pages/index.html Show resolved Hide resolved
test/functional/fixtures/regression/gh-7377/test.js Outdated Show resolved Hide resolved
test/functional/fixtures/regression/gh-7377/testcafe-fixtures/index.js Outdated Show resolved Hide resolved
@PavelMor25 PavelMor25 temporarily deployed to CI October 23, 2023 07:05 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 temporarily deployed to CI October 23, 2023 08:46 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 temporarily deployed to CI October 23, 2023 10:55 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 changed the title update scroll fixing incorrect scroll to element obscured by sticky element Oct 23, 2023
@PavelMor25 PavelMor25 temporarily deployed to CI October 30, 2023 09:35 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 closed this Oct 30, 2023
@PavelMor25 PavelMor25 reopened this Oct 30, 2023
@need-response-app need-response-app bot added STATE: Need response An issue that requires a response or attention from the team. and removed STATE: Need response An issue that requires a response or attention from the team. labels Oct 30, 2023
@PavelMor25 PavelMor25 temporarily deployed to CI October 30, 2023 09:36 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev marked this pull request as ready for review November 10, 2023 11:09
@AlexKamaev AlexKamaev merged commit 21b44a0 into DevExpress:master Nov 10, 2023
25 checks passed
@github-actions GitHub Actions
Copy link

Release v3.5.0-rc.1 addresses this.

1 similar comment
@github-actions GitHub Actions
Copy link

Release v3.5.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexKamaev AlexKamaev AlexKamaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PavelMor25 @AlexKamaev