Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance HTML and CSS to be Mobile-First #1

Merged
merged 9 commits into from
Nov 6, 2022
Merged

Enhance HTML and CSS to be Mobile-First #1

merged 9 commits into from
Nov 6, 2022

Conversation

DevLab2425
Copy link
Owner

@DevLab2425 DevLab2425 commented Nov 4, 2022 •
edited
Loading

Changes Made

  • Relocated JS to a separate file
    • Created a namespaced object to remove functions from global namespace
  • Relocate CSS to separate file
  • Refactor some JS to simplify the functionality
  • Round results up to next highest since can't build partial buildings

Screenshots

Production Rate

Screen Shot 2022-11-04 at 03 34 37

Building Support

Screen Shot 2022-11-04 at 03 37 19

Results Example

Screen Shot 2022-11-04 at 03 35 08

TODO

  • Remove remaining legacy code
  • Standardize class and id names (camelCase, snake_case, kebob-case?)
  • Convert to use ES2015+ syntax (no var, etc)

@DevLab2425 DevLab2425 mentioned this pull request Nov 4, 2022
Open
@github-pages github-pages bot temporarily deployed to github-pages November 4, 2022 07:44 Inactive
@DevLab2425 DevLab2425 merged commit d5bac7b into main Nov 6, 2022
@DevLab2425 DevLab2425 deleted the mobile-first branch November 6, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DevLab2425