-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pure Python API #714
Pure Python API #714
Conversation
… but behavior not tested at all
I managed to track down the build version issue. It was buried in the developer dependencies within the setup.py file. I also discovered various places where name changes (i.e. adding a space to a plugin name) weren't properly propagated into the implementation and corrected those. I'm about to push these updates, and hopefully the CI will pass again. Then I'll go back to looking at PR comments and recommendations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team reviewed the latest from an operational stance and the issues we were seeing have been resolved, all comments and suggestions applied to the PR have been addressed, applied, and resolved. So, we should finally be good to move forward. All follow up tasks have been documented for later application and associated work has been evaluated for close out.
All suggestions, requests, and comments have been engaged, incorporated, or captured as follow on effort. He's no longer an active member of the team so cannot remove the "changes requested" himself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paired in team session for final review
Description
Significantly reworked the AaC internal API. Now instead of navigating through dicts we have "real classes" to work with. The details are all captured on discussion #691.
Linked Items:
Resolves #691
Added
usecase
Changed
io
(which is nowin_out
for naming reasons)context
moduleexecute
moduleplugins
with no distinction between 1st and 3rd party any morevalidate
tocheck
and rewrote most of it to accommodate the newconstraint
definition approach.model
directory into thefeatures
directory and converted it into an automated acceptance test location. Behave is now integrated to ensure we don't break any of our acceptance tests as we go forward.Deprecated
LanguageContext
which now serves as a singleton for all things AaC.Removed
Fixed
Security
Checklist: