Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows color accent fully changes the UI theme #1191

Closed
Mikaz-fr opened this issue Jun 11, 2024 · 6 comments · Fixed by #1223
Closed

Windows color accent fully changes the UI theme #1191

Mikaz-fr opened this issue Jun 11, 2024 · 6 comments · Fixed by #1223
Labels
bug Something isn't working

Comments

@Mikaz-fr
Copy link

Current behavior

On Windows 10 the UI theme is fully picking up the OS color accent (see screenshots).
This happens when an accent is set and option "Title bars and window borders" is enabled.
I would expect that the UI respect the them Dark / Light option instead, I don't want to change my accent for the UI to look dark.
I'm using DevToys 2.0-preview.1 portable x64.

How to reproduce it (as minimally and precisely as possible)

In Windows 10 setting set a Color accent Settings -> Personalization -> Colors and enable "Title bars and windows borders" under section "Show accent color on the following surfaces" (see screenshots).
Start DevToys 2.0-preview.1 and see the color being overall the UI.

Expected behavior

The UI theme to remain dark even when Colors accent option "Title bars and window borders" is enabled.

Screenshots

UI look with option "Title bars and window borders" enabled:
accent_pr1

Without option "Title bars and window borders" enabled:
accent_pr2

Workaround

No response

Affected platforms

Windows

Affected DevToys kind

DevToys (app with GUI)

DevToys Version

DevToys 2.0-preview.1 portable x64

Relevant Assets/Logs

No response

@Mikaz-fr Mikaz-fr added bug Something isn't working untriaged labels Jun 11, 2024
@Mikaz-fr
Copy link
Author

I searched the repo and found that it might be related to pull request #112.
But the screenshot there had option "Title bars and windows borders" disabled so I don't know if the behavior was the same.

@veler veler mentioned this issue Jun 14, 2024
18 tasks
@veler veler linked a pull request Jun 14, 2024 that will close this issue
18 tasks
@veler
Copy link
Collaborator

veler commented Jun 14, 2024

Thanks! I got a fix here: #1223

@andercard0
Copy link

Hi,

I'm not sure if this is related but take a look in the gif, the problem is, the dark theme isn't being applied correctly, tried to set up as system default but no deal it stays in blue, but, if i change the focus window it returns to black/dark theme.

If is not related please let me know and I'll raise a issue.
bug

@veler
Copy link
Collaborator

veler commented Jun 15, 2024

Hi @andercard0,
It's related, and my pull request address this issue too :)

@veler veler removed the untriaged label Jun 15, 2024
@andercard0
Copy link

Hi @andercard0,
It's related, and my pull request address this issue too :)

Great thanks. I will for the artefacts in mentioned PR.

@veler
Copy link
Collaborator

veler commented Jun 19, 2024

Thanks. A fix is available in DevToys 2.0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants