Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a copy button to the MarkdownPreview tool to copy the HTML output #260

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Add a copy button to the MarkdownPreview tool to copy the HTML output #260

merged 2 commits into from
Jan 29, 2022

Conversation

praneetloke
Copy link
Contributor

@praneetloke praneetloke commented Jan 26, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

There is no way to copy the HTML output from the markdown preview.

Issue Number: N/A

What is the new behavior?

A new copy button above the Webview control allows the user to copy the contents of the markdown-body element.

Screenshot Screenshot 2022-01-25 181200

Other information

I am a newbie at UWP app development and especially with the MVVM pattern.

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
    • I could not get this to work on my machine for some reason even though my changes should not affect the Release build config. I was getting an error about a SetVersion task being unable to run because Microsoft.Build.Utilities version 3.5.0.0 wasn't available despite having a successful Nuget restore.
  • Checked all unit tests pass

@praneetloke
Copy link
Contributor Author

@veler I've updated the PR. Can you please take another look?

@veler
Copy link
Collaborator

veler commented Jan 29, 2022

Awesome! It looks all good :) Thank you for this!

@veler veler merged commit 3e03b8a into DevToys-app:main Jan 29, 2022
veler pushed a commit that referenced this pull request Mar 31, 2023
…#260)

* Add a copy button to the MarkdownPreview tool

* Address PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants