Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add folder browser for image compression #304

Closed

Conversation

youkai95
Copy link
Contributor

Closes #259 This feature is only working for the image compression tool. I know there is a refactorization of the component around, so I would like to leave the feature here for your consideration. Please, do not consider the UI desing... I am really bad with it.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

Issue Number: #259

What is the new behavior?

  • You can choose a folder to optimize images inside it

Other information

I do not consider the UI design to be pretty. I am accepting any kind of fix/redesign/etc if this PR could be accepted.

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler
Copy link
Collaborator

veler commented Jan 30, 2022

Hello,

Thank you for this contribution. :)
As you mentioned, I'm working on a reusable control for selecting files. Being able to select a browser is a great idea!
If that's OK, I will use part of what you did here in the control I'm making so it supports folders too.

Thank you again for this contribution and idea!

@veler veler closed this Jan 30, 2022
@youkai95
Copy link
Contributor Author

Hello,

Thank you for this contribution. :) As you mentioned, I'm working on a reusable control for selecting files. Being able to select a browser is a great idea! If that's OK, I will use part of what you did here in the control I'm making so it supports folders too.

Thank you again for this contribution and idea!

No problem, I am grateful that this contribution helps somehow ;)

@veler
Copy link
Collaborator

veler commented Jan 30, 2022

@youkai95 , I just finished the component in question :-D You can take a look at it here if you want: #308

@youkai95 youkai95 deleted the image-compression-folder-browser branch January 30, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNG / JPEG Compressor: Optimize images from a folder
2 participants