Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where Monaco Editor isn't clickable when NavigationView is in Compact state. #56

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

veler
Copy link
Collaborator

@veler veler commented Oct 31, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

When the app starts with NavigationView in Compact mode, the layout seems broken and Monaco Editor can't be focused until the app goes to Expanded mode (and goes back to Compact, if wanted).

image

Issue Number: #54

What is the new behavior?

Fixed the issue by forcing the view to start in Expanded view, and then switch to Compact view is needed.

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler added the bug Something isn't working label Oct 31, 2021
@veler veler linked an issue Oct 31, 2021 that may be closed by this pull request
@veler veler merged commit a8739a5 into main Oct 31, 2021
@veler veler deleted the bug54 branch October 31, 2021 21:52
veler added a commit that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monaco Editor activation issue
1 participant