Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all Module path aliases #63

Merged
merged 3 commits into from
Nov 26, 2021

Conversation

frankTurtle
Copy link
Contributor

What does it fix?

Solves #61
No longer using ../../../../folder/lib imports in the client folder

Notes

For some reason the aliases don't work?

@vercel
Copy link

vercel bot commented Nov 19, 2021

@frankTurtle is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

@with-heart with-heart linked an issue Nov 19, 2021 that may be closed by this pull request
@with-heart with-heart self-requested a review November 19, 2021 05:51
@G3root
Copy link
Contributor

G3root commented Nov 19, 2021

Absolute imports makes it easier to move files around and avoid messy import paths such as ../../../Component.

Other than having multiple paths for different folders (such as @components, @hooks, etc...) , Using @/* or ~/* works very well because it is short enough so there is no need to configure multiple paths and it differs from other dependency modules, so there is no confusion in what comes from node_modules and what is our source folder.

Example config for current structure.

// tsconfig.json
"compilerOptions": {
    "baseUrl": ".",
    "paths": {
      "@/*": ["*"]
    }
  }

@carlomigueldy
Copy link
Contributor

Absolute imports makes it easier to move files around and avoid messy import paths such as ../../../Component.

Other than having multiple paths for different folders (such as @components, @hooks, etc...) , Using @/* or ~/* works very well because it is short enough so there is no need to configure multiple paths and it differs from other dependency modules, so there is no confusion in what comes from node_modules and what is our source folder.

Example config for current structure.

// tsconfig.json
"compilerOptions": {
    "baseUrl": ".",
    "paths": {
      "@/*": ["*"]
    }
  }

Yup let's go with this one @frankTurtle

@frankTurtle
Copy link
Contributor Author

I'll get this pushed tomorrow, sorry for the delay!

@frankTurtle frankTurtle marked this pull request as ready for review November 24, 2021 03:35
@frankTurtle frankTurtle changed the title [WIP] Updated all Module path aliases in the /client Updated all Module path aliases Nov 24, 2021
@frankTurtle
Copy link
Contributor Author

Give 'er a look-see @with-heart && @carlomigueldy

@vercel
Copy link

vercel bot commented Nov 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/developdao/dao-job-board/ESw7jodffFKYea1A2w5TuabMycHR
✅ Preview: https://dao-job-board-git-fork-frankturtle-feature-pa-85ae14-developdao.vercel.app

@carlomigueldy carlomigueldy merged commit 5fb305d into Developer-DAO:main Nov 26, 2021
@frankTurtle frankTurtle deleted the feature/pathAliases branch November 26, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of path aliases
4 participants