Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues in index/profile #32

Merged

Conversation

andyrobert3
Copy link
Contributor

@andyrobert3 andyrobert3 commented Nov 12, 2022

Resolves the failed yarn build when building the subgraph

Issue with JS newest syntax ? && ?? null coalescing operators

Test plan
Ran yarn build locally, build was successfully generated

@Nazeeh21 we should consider putting config for spacing (tabs vs spaces) to prevent the diffs in each PR to be just filled with spaces

@andyrobert3 andyrobert3 changed the title Create remaining event handlers Fix build issues in index/profile Nov 14, 2022
@Nazeeh21 Nazeeh21 self-requested a review November 14, 2022 11:46
Copy link
Member

@Nazeeh21 Nazeeh21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nazeeh21 Nazeeh21 merged commit cbf9195 into Developer-DAO:feat/index-profile Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants