-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added hardhat project for pixel avatars #23
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/developdao/pixel-avatars/DejHYrapoYEpConJ9hVnie2mbJL5 |
This PR contains:
|
Thanks for putting this in @etherinsight! I was wondering why is it that you chose not to import the source code for these utility contracts: (I'm not experienced w/ mainnet contract development so let me know if this is a common practice for mainnet/prod) |
@Dhaiwat10 I used a flattened code file as my reference which has all the required modules ERC721Enumerable, ReentrancyGuard, Ownable in that single solidity file. A command like this will create a single file including all imports like ERC721, Ownable etc
|
Gotcha. I got to read up on this later and found out that flattened contracts are required(?) if you want your contract to be 'verified' on Etherscan. Is that correct? |
Else, this looks good to me. Let's get this merged and add tests? |
//Private sale minting (reserved for DevDao owners) | ||
function mintWithDevDaoToken(uint256 DevDaoTokenId) | ||
public | ||
payable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this payable tho?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reposting my comment as etherinsight again 😅
good catch. Not sure why this was kept payable on my reference contract. I'll remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha cool
This is a working version of the hardhat solidity project for pixel avatars.