Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 패딩 값 수정 #88

Merged
merged 1 commit into from
Feb 5, 2023
Merged

[Feat] 패딩 값 수정 #88

merged 1 commit into from
Feb 5, 2023

Conversation

JIWON1923
Copy link
Member

Keychanges

Screenshots

iPhone13 iPhoneSE iPhone14ProMax

To Reviewer

  • 이미지의 width, height 을 모두 지정하고, scale to Fill 을 수행하게 되면 컴포넌트 사이 중첩이 발생합니다. (글자가 이미지에 가려지는 이슈가 발생해요) 정해진 크기보다 더 큰 영역을 차지하기 때문입니다!
  • 이에 이미지의 width만 지정하고, scale to fit으로 설정하여 이슈를 해결하였습니다.

@JIWON1923 JIWON1923 added the 🖼 design UI 수정필요 label Feb 1, 2023
@JIWON1923 JIWON1923 self-assigned this Feb 1, 2023
@JIWON1923
Copy link
Member Author

카톡 Approve 받아 머지합니다~!

@JIWON1923 JIWON1923 merged commit 7fb8626 into develop Feb 5, 2023
@JIWON1923 JIWON1923 deleted the HomeView/design branch February 5, 2023 03:52
@JIWON1923 JIWON1923 mentioned this pull request Feb 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JIWON1923 JIWON1923

Labels
🖼 design UI 수정필요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] HomeView Padding 조절
1 participant
@JIWON1923