Make links more obvious #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eakam1007
added
category: front end
humphd
approved these changes
Apr 7, 2023
Ririio
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #539
This changes all Chakra UI
LinkComponents to have a base color of red (from our color theme), and a base text decoration of underline:Since this only changes the base style, you can override the style as you normally would for any Charka UI component. Eg:
I have also updated the landing page links to use Charka UI's
Linkcomponent, but as Remix's Link component. This preserves client-side routing but also keeps the Chakra UI styles (Relevant Chakra UI docs)Steps to test