This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Bitfinex WS Fixes: Reconnect and crash on previously non-traded assets/currency #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviaVir
approved these changes
Aug 14, 2017
nedievas
reviewed
Aug 15, 2017
| @@ -46,13 +46,13 @@ module.exports = function container (get, set, clear) { | |||
| } | |||
| ws_trades.push(newTrade) | |||
| }) | |||
|
|
|||
nedievas
reviewed
Aug 15, 2017
| @@ -65,7 +65,7 @@ module.exports = function container (get, set, clear) { | |||
| if (message[0] != "undefined") | |||
nedievas
reviewed
Aug 15, 2017
| return cb(null, order) | ||
| } else if (order.status === 'rejected' && order.reject_reason === 'zenbot canceled') { | ||
| return cb(null, order) | ||
| return cb(null, order) | ||
| } | ||
|
|
nedievas
approved these changes
Aug 15, 2017
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
…s/currency (DeviaVir#474) * Bitfinex WS: Fix reconnect * Bitfinex WS: Report wallet balance as 0, when an unknown pair is traded for the first time on Bitfinex * Bitfinex WS: Removed a bunch of trailing white spaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. Also removed some trailing white spaces.
@nedievas?