This repository was archived by the owner on Sep 7, 2019. It is now read-only.
Pull in upstream fix for PHP hostname and SSL when creating new socket #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comments? I think this is an important fix for PHP 5.6, and is holding back the Slack realtime client I maintain from supporting PHP 5.6. |
|
thank you for the fix, looks great, hope this will be accepted soon |
|
+1, merge pls! |
Devristo
added a commit
that referenced
this pull request
Jul 10, 2015
Pull in upstream fix for PHP hostname and SSL when creating new socket
|
Merged, sorry guys. I haven't been active lately... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 5.6 has a few changes on how SSL is handled; hostnames are now verified during the SSL handshake. This issue was already fixed in react/socket-client here, but the changes didn't cascade since the changed method is overriden in
Devristo\Phpws\Client\Connector. This should fix #60 (and maybe other SSL-related bugs).