Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added authentication system and chat group system #123

Merged
merged 8 commits into from
Jun 2, 2021

Conversation

robinsingh-ai
Copy link
Contributor

@robinsingh-ai robinsingh-ai commented Mar 28, 2021

Solves conflicting files issues in #107 PR
Solves #31
Screenshots
React Messenger App SS 1

React Messenger App SS 2

React Messenger APP ss 3

@abhijeet007rocks8
Copy link
Collaborator

@Robin025 looks good to me can you just replace the time shown in the messages to how its being shown in the current version.

@DhairyaBahl Review it once. I did but you should do to and then merge it.

Copy link
Owner

@DhairyaBahl DhairyaBahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robin025 You did a great Job !! Superb ! Just fix the time to how it is being shown right now ! Rest seems perfect to me. Really appreciate the effort ^_^

@robinsingh-ai
Copy link
Contributor Author

@Robin025 You did a great Job !! Superb ! Just fix the time to how it is being shown right now ! Rest seems perfect to me. Really appreciate the effort ^_^

Actually @DhairyaBahl and @abhijeet007rocks8 the time which we are showing is the server time stamp
For example if someone msgs from uk so their local time will be completely different from us...so that's why I used this server timestamp which Google Firebase uses.

@abhijeet007rocks8
Copy link
Collaborator

@Robin025 You did a great Job !! Superb ! Just fix the time to how it is being shown right now ! Rest seems perfect to me. Really appreciate the effort ^_^

Actually @DhairyaBahl and @abhijeet007rocks8 the time which we are showing is the server time stamp
For example if someone msgs from uk so their local time will be completely different from us...so that's why I used this server timestamp which Google Firebase uses.

You can get the device timezone and make the time difference accordingly

@abhijeet007rocks8 abhijeet007rocks8 merged commit 082ef78 into DhairyaBahl:master Jun 2, 2021
@abhijeet007rocks8 abhijeet007rocks8 added GSSoC21 Mandatory Tag Level3 New features, major bug fixing labels Jun 2, 2021
@robinsingh-ai
Copy link
Contributor Author

Hello @DhairyaBahl ,
I had a discussion with Praveen who is doing all the leaderboard stuff of GSSoC21 and he told all of us that the GSSoC21 tag should look like GSSoC21 and it's case sensitive, so if the tag doesn't look like this GSSoC21 then that PR will not be counted, so can you please update the tag in all my PRs thatbhave reference to issue #123

Thankyou

@abhijeet007rocks8
Copy link
Collaborator

Hello @DhairyaBahl ,
I had a discussion with Praveen who is doing all the leaderboard stuff of GSSoC21 and he told all of us that the GSSoC21 tag should look like GSSoC21 and it's case sensitive, so if the tag doesn't look like this GSSoC21 then that PR will not be counted, so can you please update the tag in all my PRs that have reference to issue #123

Thankyou

During Previous stages also this label was used and the merges of other were considered and points were appointed. Can you reconfirm with him??

@robinsingh-ai
Copy link
Contributor Author

Hello @DhairyaBahl ,
I had a discussion with Praveen who is doing all the leaderboard stuff of GSSoC21 and he told all of us that the GSSoC21 tag should look like GSSoC21 and it's case sensitive, so if the tag doesn't look like this GSSoC21 then that PR will not be counted, so can you please update the tag in all my PRs that have reference to issue #123
Thankyou

During Previous stages also this label was used and the merges of other were considered and points were appointed. Can you reconfirm with him??

Hello @abhijeet007rocks8
Really sorry for inconvenience, actually I was initially perplexed by the GSSoC21 label tag issue, but eventually realised that these labels are case insensitive, so no need to change this
Again sorry for the inconvenience

Thank you

@abhijeet007rocks8
Copy link
Collaborator

Hello @DhairyaBahl ,
I had a discussion with Praveen who is doing all the leaderboard stuff of GSSoC21 and he told all of us that the GSSoC21 tag should look like GSSoC21 and it's case sensitive, so if the tag doesn't look like this GSSoC21 then that PR will not be counted, so can you please update the tag in all my PRs that have reference to issue #123
Thankyou

During Previous stages also this label was used and the merges of other were considered and points were appointed. Can you reconfirm with him??

Hello @abhijeet007rocks8
Really sorry for inconvenience, actually I was initially perplexed by the GSSoC21 label tag issue, but eventually realised that these labels are case insensitive, so no need to change this
Again sorry for the inconvenience

Thank you

Fixed It.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSoC21 Mandatory Tag Level3 New features, major bug fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants